RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

Florian Kirmaier fkirmaier at openjdk.java.net
Tue Sep 28 12:15:30 UTC 2021

On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> When using Swing it's possible to generate a Deadlock.
>>  It's related to the nested eventloop started in enterFullScreenExitingLoop - and the RenderLock aquired when using setView in Scene.
>>  Sample Programm and Threaddump are added to the ticket.
>> Removing the nested loop fixes the Problem. 
>> I hope this doesn't have any side effect - so far i don't know of any.
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>   JDK-8273485
>   removed the toggle fullscreen before closing - to avoid the beep and improve the user experience

I've just noticed that I've missed to commit a change, to prevent the beep - which I've now added.

The changes I've now committed also have another welcome side effects:
JavaFX behaves more like "normal" Mac apps.
 - Animation out of fullscreen
 - Closing the window
 - Closing the window
This is how other mac applications behave - and should probably therefore be preferred. I've tested it with apps like Finder, Textedit, Chrome, Safari.


PR: https://git.openjdk.java.net/jfx/pull/622

More information about the openjfx-dev mailing list