RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

Kevin Rushforth kcr at openjdk.java.net
Wed Sep 29 11:53:47 UTC 2021

On Tue, 28 Sep 2021 17:19:38 GMT, Michael Paus <mpaus at openjdk.org> wrote:

> First of all. Shall I follow the bot request above and create a new pull request? Wouldn't we loose the discussion here then?

As long as you don't otherwise need to update your `master` branch, you can wait to reset it until after this PR is integrated. If you prefer to create a new branch and a new PR, then you could link to the discussion. I'll leave it up to you.

> I have no idea about LSOpenURLsWithRole. I am not a Mac developer.

I think calling `Runtime::exec("open", uri)` is fine. It matches the behavior on Windows and Linux. I'll do some testing, but I don't anticipate any problems.

> I have manually tested the change.

In that case, can you create a new manual test as part of this PR? I recommend a new directory: `tests/manual/desktop/HostServices` (my thinking is that `tests/manual/desktop` could eventually include tests for `FileChooser` or other similar manual tests). I'm open to other names as well. You can look at `tests/manual/web/InputTypeAcceptAttributeTest.java` for an example of a good manual test. I recommend adding at least a `.txt` and a `.html` file. You can hard-code the filenames so you don't need to use a `FileChooser`.


PR: https://git.openjdk.java.net/jfx/pull/634

More information about the openjfx-dev mailing list