[foreign] RFR 8221471: jextract source genarator generates non-compilable classes with naming clashes
jbvernee at xs4all.nl
Tue Apr 9 17:37:04 UTC 2019
Windows has some failures, seemingly from to va_list patch.
1.) small typo in IncompleArrayTest (for the Windows-only case):
2.) ValistUseTest itself fails. It looks like the builtin$.h header is
missing from src/jdk.jextract/share/conf for some reason , I guess it
got dropped from the push by accident? But, after I added that the test
I manually ran jextract on the test header, which works. The generated
method uses Pointer<Byte> for the va_list, so it looks like the backing
impl is different on Windows, and there's no need for jextract to
generate the __va_list_tag struct in clang_support.builtin$_h that the
test is checking for, so the test fails.
Could go with adding `@requires os.family != "windows"` to ValistUseTest
After those 2 fixes the tests are all green on my machine :)
Maurizio Cimadamore schreef op 2019-04-09 18:20:
> Looks good!
> A multi-platform test run is probably better here :-)
> On 09/04/2019 16:55, Sundararajan Athijegannathan wrote:
>> Please review.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221471
>> Current naming scheme: Header interfaces are named as "foo". Static
>> forwarder class is named as "foo_h"
>> New naming scheme: Header interfaces are named as "foo_h". Static
>> forwarder class is named as "foo_lib"
More information about the panama-dev