[foreign] RFR 8222765: Implement foreign memory access through VarHandle
maurizio.cimadamore at oracle.com
Fri Apr 19 17:55:35 UTC 2019
After a closer look, it seems like the first parameter to the macro is
not used. The macro GenerateVarHandleXYZ does, as its first thing:
$1_Type := $2
And then keeps using $1_Type after that.
Maybe the $1 parameter is some remains of older code.
On 19/04/2019 17:42, Maurizio Cimadamore wrote:
> On 19/04/2019 16:46, Jorn Vernee wrote:
>> - In GensrcVarHandles.gmk you seem to have a mistake in the
>> generation command:
>> 274 # List the types to generate source for, with capitalized first
>> 275 VARHANDLES_MEMORY_ADDRESS_TYPES := Byte Short Char Int Long
>> Float Double
>> 276 $(foreach t, $(VARHANDLES_MEMORY_ADDRESS_TYPES), \
>> 277 $(eval $(call
>> You still have to change the name VAR_HANDLE_BYTE_ARRAY_ to something
>> else (probably forgotten when copy pasting?)
> Good point, I wonder why it still works??? I'll take another look.
> The right classes are definitively generated.
More information about the panama-dev