[Integrated] [foreign-jextract] RFR: 8244244: Better representing typedef in jextract API
henryjen at openjdk.java.net
Fri May 1 15:39:47 UTC 2020
On Thu, 30 Apr 2020 06:29:29 GMT, Henry Jen <henryjen at openjdk.org> wrote:
> Currently jextract API only present typedef declaration for record types, and using Declaration.Scoped to do so.
> This makes downstream tools like jextract impossible to generate more comprehensive type. For example, if the tool
> would like to create a carrier type for size_t with similar name, because we pass through that, this is impossible.
> This patch try to present typedef as Declaration.Variable with Kind TYPE. This will give us more transparency on
> dealing with typedef, and enable factoring an Declaration.Variable.TYPE from a Type.Delegated.TYPEDEF.
> This would also be useful when a tool collecting type dependencies and encounter anonymous type or types without
> declaration, this gave the tool a chance to inject an implicit typedef to associate a type with a proper name.
> There is one thing worth further discussion is that if we would like to consider generate array with typedef, currently
> the array element type won't be a Type.Delegated.TYPEDEF, but canonical type. The test case try to explain what should
> be expected for most use cases, if there is any possible way to use typedef, I'll try to add them.
This pull request has now been integrated.
Author: Henry Jen <henryjen at openjdk.org>
Stats: 553 lines in 9 files changed: 13 ins; 517 del; 23 mod
8244244: Better representing typedef in jextract API
Reviewed-by: mcimadamore, sundar
More information about the panama-dev