[vector] RFR:8244269: vector api tests crashed with "assert(is_location()) failed: must be"

Paul Sandoz paul.sandoz at oracle.com
Thu May 7 01:22:22 UTC 2020

Looks good.

Would you mind wrapping lines longer that 120 characters? Otherwise its hard to read and review.
Specifically, in the argument accepting iotaShuffle method e.g. start the lambda expression on a new line.
No need for another review.


> On May 6, 2020, at 6:14 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com> wrote:
> Please find below a webrev which cleans up the slice(), unslice() and iotaShuffle() implementations and fixes the assert(is_location()).
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/8244269/webrev.00/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/8244269/webrev.00/>
> 27 of the 29 Vector API test failures with -Xcomp pass with this patch.
> The remaining two are a different assert and will be taken up separately.
> Best Regards,
> Sandhya

More information about the panama-dev mailing list