[vector] Remove Vector.fromValues

Viswanathan, Sandhya sandhya.viswanathan at intel.com
Wed May 13 20:36:10 UTC 2020

Looks good to me.

Best Regards,

-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Paul Sandoz
Sent: Wednesday, May 13, 2020 11:42 AM
To: panama-dev at openjdk.java.net' <panama-dev at openjdk.java.net>
Subject: [vector] Remove Vector.fromValues


Please review the following that removes Vector.fromValues:

  http://cr.openjdk.java.net/~psandoz/panama/vector-rm-fromValues/webrev/ <http://cr.openjdk.java.net/~psandoz/panama/vector-rm-fromValues/webrev/>

This method is not well optimized and it likely never will be particularly efficient since constructing a vector from values through a temporary buffer or explicit insertion will have a cost.   

The workaround is to use fromArray or the explicit withLane, which I think is fine for constructing vector constants (those constant within a loop or otherwise), and bring to the foreground the potential costs.


More information about the panama-dev mailing list