[foreign-memaccess] RFR: 8246053: Add a mask for default access modesAdd a default access mode flag

Chris Hegarty chegar at openjdk.java.net
Thu May 28 14:48:09 UTC 2020

On Thu, 28 May 2020 13:28:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This is a simple change which adds a 'default' access mask. This was pointed out during CSR review, and I realized that
> many tests were also using it. It can also be handy when creating more restricted masks (e.g. start with default and
> remove one or two access modes).
> I've updated tests, documentation and some of the impl to use the new mask accordingly.

This looks good. I've ended up doing similar in tests too, so I think that this is a good addition.

I might quibble about the name, why`DEFAULT_ACCESS` and not something like `ALL_MODES`, or `ALL_ACCESS`, or some such?


Marked as reviewed by chegar (no project role).

PR: https://git.openjdk.java.net/panama-foreign/pull/188

More information about the panama-dev mailing list