[vectorIntrinsics] RFR: 8261108: Add cast nodes from integer types to float types implementation for Arm SVE [v2]

Xiaohong Gong xgong at openjdk.java.net
Sat Feb 20 10:07:53 UTC 2021

On Fri, 19 Feb 2021 08:34:27 GMT, Ningsheng Jian <njian at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>>   fix some bugs
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 3371:
>> 3369:     } else if (T_dst == D && T_src == S) {
>> 3370:       T_dst = D;
>> 3371:       T_src = B;
> This looks confusing. I understand that it's just 0b00, but using B here is really confusing. Maybe using 0b00 and 0b11 directly to align with Arm ARM opc/opc2?

I agree with @nsjian that swapping "T_dst" and "T_src" is confusing although this can generate the same final result.  As I understand that this function is used to generate two opcs from the dst and src type, I'd like not using the swap logic. Thanks!


PR: https://git.openjdk.java.net/panama-vector/pull/37

More information about the panama-dev mailing list