[foreign-memaccess+abi] RFR: 8262118: Specialize upcalls

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Feb 22 13:24:54 UTC 2021

On Mon, 22 Feb 2021 13:15:43 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> test/jdk/java/foreign/TestUpcall.java line 33:
>>> 31:  * @run testng/othervm
>>> 32:  *   -Dforeign.restricted=permit
>>> 33:  *   TestUpcall
>> Here, in addition to reverting these changes, we should also test with all the new flavors of upcall specialization/intrinsics?
> I've tried to explain this in the PR body. Testing the current configuration already takes 15 minutes for TestUpcall. Adding the new configurations would multiply the number of configurations by 4. This seems excessive, since we mostly only use the default configuration any ways. The full matrix can be tested periodically (maybe as part of a higher tier, or CI), but for regular testing runs we could only run the default configuration?

Oops - I missed that part. On linux it doesn't take long to execute (1 min maybe) so I was surprised. But I understand it might be an issue in other platforms. That said, in the recent ResourceScope rewrite, executing using all modes has been helpful in shaking out issues, so I'm a bit worried to see this going completely. I'm pretty sure in a month I'll forget that I have to go in a manually edit to add the missing combo...


PR: https://git.openjdk.java.net/panama-foreign/pull/457

More information about the panama-dev mailing list