[foreign-memaccess+abi] RFR: 8262118: Specialize upcalls
jvernee at openjdk.java.net
Mon Feb 22 13:28:58 UTC 2021
On Mon, 22 Feb 2021 13:22:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Oops - I missed that part. On linux it doesn't take long to execute (1 min maybe) so I was surprised. But I understand it might be an issue in other platforms. That said, in the recent ResourceScope rewrite, executing using all modes has been helpful in shaking out issues, so I'm a bit worried to see this going completely. I'm pretty sure in a month I'll forget that I have to go in a manually edit to add the missing combo...
> One wacky idea: I assume these properties are not read-only - what if, the tests had an additional parameter which dictated the specific setup for generating upcall/downcalls? That way, we can decide how many stuff should be included when generating the various test combinations (and maybe just keep the main mode for standard executions).
Yes, for such big patches it seems useful, but if the linker internals are untouched not so much imo. I can look a bit more at this and separate the full configuration out into a separate test group perhaps, e.g. we'd have like `run-test-jdk_foreign` and `run-test-jdk_foreign-full` (or with the default reversed).
More information about the panama-dev