[foreign-memaccess+abi] RFR: 8262118: Specialize upcalls [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Feb 23 12:47:54 UTC 2021

On Tue, 23 Feb 2021 11:15:27 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>>  - Tab to spaces
>>  - Added TestMatrix test that test all configurations of TestUpcall TestDowncall and TestUpcallHightArity
> Looks a very solid piece of work (I've mostly checked the Java side). I like how the code has been consolidated between upcall and downcall paths. I've added some minor comments around for your consideration.

When trying this on my machine (Ubuntu 20.04) I get this:
In file included from ../../src/hotspot/share/prims/foreign_globals.cpp:25:
../../src/hotspot/share/prims/foreign_globals.hpp:40:46: error: 'VMRegPair' has not been declared
   40 |   void calling_convention(BasicType* sig_bt, VMRegPair *parm_regs, uint argcnt) const;
      |                                              ^~~~~~~~~
../../src/hotspot/share/prims/foreign_globals.cpp:102:6: error: no declaration matches 'void CallRegs::calling_convention(BasicType*, VMRegPair*, uint) const'
  102 | void CallRegs::calling_convention(BasicType* sig_bt, VMRegPair *parm_regs, uint argcnt) const {
      |      ^~~~~~~~
In file included from ../../src/hotspot/share/prims/foreign_globals.cpp:25:
../../src/hotspot/share/prims/foreign_globals.hpp:40:8: note: candidate is: 'void CallRegs::calling_convention(BasicType*, int*, uint) const'
   40 |   void calling_convention(BasicType* sig_bt, VMRegPair *parm_regs, uint argcnt) const;
      |        ^~~~~~~~~~~~~~~~~~
../../src/hotspot/share/prims/foreign_globals.hpp:33:8: note: 'struct CallRegs' defined here
   33 | struct CallRegs {
      |        ^~~~~~~~

I compile with disabled precompiled headers, which typically causes issues like this - is there some include missing somewhere?


PR: https://git.openjdk.java.net/panama-foreign/pull/457

More information about the panama-dev mailing list