[foreign-memaccess+abi] RFR: Minor Windows build fixes
mcimadamore at openjdk.java.net
Thu May 6 20:20:00 UTC 2021
On Thu, 6 May 2021 19:01:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Some minor changes to fix build errors/warnings on Windows:
> - Remove spurious `vprintf` declaration in libStdLibTest.h (it is already included as part of stdio.h). This was causing an error due to a conflicting declaration.
> - Remove `return` before free in benchmark lib. This was causing a warning that was then treated as an error.
test/jdk/java/foreign/libStdLibTest.h line 43:
> 41: EXPORT void libc_qsort(void *base, size_t nitems, size_t size, int (*compar)(const void *, const void*));
> 42: EXPORT int libc_rand(void);
> 43: EXPORT int vprintf(const char *format, va_list arg);
Something odd here - I note that the header has vprintf - but the impl has libc_vprintf - should we maybe add `libc_vprintf` in the header instead of just remove (and than make sure right symbol is used in test) ?
More information about the panama-dev