[foreign-memaccess+abi] RFR: Minor Windows build fixes [v2]
jvernee at openjdk.java.net
Thu May 6 21:08:33 UTC 2021
On Thu, 6 May 2021 20:17:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> test/jdk/java/foreign/libStdLibTest.h line 43:
>>> 41: EXPORT void libc_qsort(void *base, size_t nitems, size_t size, int (*compar)(const void *, const void*));
>>> 42: EXPORT int libc_rand(void);
>>> 43: EXPORT int vprintf(const char *format, va_list arg);
>> Something odd here - I note that the header has vprintf - but the impl has libc_vprintf - should we maybe add `libc_vprintf` in the header instead of just remove (and than make sure right symbol is used in test) ?
> Btw - do we really need an header for the test library?
Oh, ok. I misread and though vprintf was only use to forward arguments from libc_printf, and didn't see libc_vprintf is also defined.
You're right that a header file is not really needed. I'll just remove it, and move the relevant stuff to the .c file instead.
More information about the panama-dev