[foreign-memaccess+abi] RFR: 8266814: Improve library loading with SymbolLookup abstraction [v3]
mcimadamore at openjdk.java.net
Mon May 10 16:57:31 UTC 2021
> This patch implements the library loading abstraction described in:
> That is, a functional interface called `SymbolLookup`, and a couple of factories to get a lookup for a given classloader, and to get a *system* lookup, useful to lookup C symbols.
> To implement the system lookup, we load `msvcrt.dll` on Windows, while we build and load an empty library (which depends on libc) on Mac/Linux. This approach is better than relying on RTLD_DEFAULT (which can sometimes leak symbols from libraries loaded independently). Also, doing this bypasses the problem of figuring out the location of libc, which, on Linux system is particularly gnarly, because of the multi-arch support.
Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
Address review comments
- all: https://git.openjdk.java.net/panama-foreign/pull/531/files
- new: https://git.openjdk.java.net/panama-foreign/pull/531/files/0a051573..1b5f0871
- full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=531&range=02
- incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=531&range=01-02
Stats: 31 lines in 2 files changed: 7 ins; 23 del; 1 mod
Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/531/head:pull/531
More information about the panama-dev