[foreign-memaccess+abi] RFR: Remove printf and vprintf tests [v2]
mcimadamore at openjdk.java.net
Fri May 14 12:24:49 UTC 2021
On Fri, 14 May 2021 12:18:32 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> This patch removes the printf and vprintf tests, since the symbols are not available on Windows in the UCRT.
>> gmtime is similarly an inline function that maps to something else, but in that case there is a drop-in replacement symbol name _gmtime64 we can call instead.
>> This fixes the missing symbol errors in StdLibTest.
> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
> - Rather than removing or disabling tests on Windows, fall back to a helper library that can return the right function addresses to us.
> - Only disable tests on Windows instead.
Looks good. One possible simplification would be, since you already have a supporting library for windows, to just define printf/vprintf/gmtime there, and then define a lookup that first looks in systemLookup and then falls back in the loader lookup. In fact, you could define the test lookup always in this way, and just do a System.loadLibrary in the windows case.
Marked as reviewed by mcimadamore (Committer).
More information about the panama-dev