[foreign-memaccess+abi] RFR: Remove printf and vprintf tests [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Fri May 14 12:59:01 UTC 2021

On Fri, 14 May 2021 12:42:31 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This patch removes the printf and vprintf tests, since the symbols are not available on Windows in the UCRT.
>> gmtime is similarly an inline function that maps to something else, but in that case there is a drop-in replacement symbol name _gmtime64 we can call instead.
>> This fixes the missing symbol errors in StdLibTest.
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>   Replace get_ptr function with function table

Marked as reviewed by mcimadamore (Committer).

test/jdk/java/foreign/NativeTestHelper.java line 33:

> 31: public class NativeTestHelper {
> 32: 
> 33:     public static final boolean IS_WINDOWS = System.getProperty("os.name").startsWith("Windows");

This is never used

test/jdk/java/foreign/StdLibTest.java line 53:

> 51: import static jdk.incubator.foreign.MemoryAccess.*;
> 52: 
> 53: import org.testng.SkipException;

Still needed?


PR: https://git.openjdk.java.net/panama-foreign/pull/536

More information about the panama-dev mailing list