[foreign-memaccess+abi] RFR: 8267989: Exceptions thrown during upcalls should be handled
mcimadamore at openjdk.java.net
Mon May 31 17:54:58 UTC 2021
On Mon, 31 May 2021 17:39:41 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> This patch regularizes exception handling for exceptions thrown during upcalls. Exceptions thrown during upcalls are now always handled by printing out the stack trace and then calling `System::exit` (see the JBS issue for some motivation).
> I've added some documentation for the exception handling to `CLinker::upcallStub`, as well as a new public `int` constant in `CLinker` which is the error code that is passed to `System::exit`. The returned error code can also be configured by a system property, which for now is mostly useful for testing purposes to make sure we don't get a consistent false positive.
src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java line 123:
> 121: * @see CLinker#upcallStub(MethodHandle, FunctionDescriptor, ResourceScope)
> 122: */
> 123: int ERR_UNCAUGHT_EXCEPTION = privilegedGetProperty("jdk.incubator.foreign.uncaught_exception_code", 1);
Do we need a system property? E.g. can it be a constant value?
test/jdk/java/foreign/TestUpcallException.java line 80:
> 79: int result = process.waitFor();
> 80: assertEquals(result, exitCode);
Should we check for stacktrace output - e.g. the name of ThrowingUpcall" ?
Marked as reviewed by mcimadamore (Committer).
More information about the panama-dev