8165103: Update to "denyAfter constraint check" exception message

Anthony Scarpino anthony.scarpino at oracle.com
Thu Oct 6 03:29:59 UTC 2016


This is intentional as an optimization. Setting the String is only 
needed in the failure case, so I separated them to optimize the success 
case.  That's why I have the comment there.

Tony

On 10/05/2016 04:58 PM, Valerie Peng wrote:
>
> Instead of duplicating the if-check block, how about just add another
> String variable "dateType" and assign value to it in the first if-check
> block?
> Rest looks fine.
> Valerie
>
> On 10/5/2016 1:20 PM, Anthony Scarpino wrote:
>> Hi,
>>
>> I'd like a review of this change away from a generic error messages in
>> the denyAfter constraint.  The message better specify which date was
>> checked against the constraint now. Testing is handled elsewhere.
>>
>> http://cr.openjdk.java.net/~ascarpino/8165103/webrev/
>>
>> Tony
>>
>



More information about the security-dev mailing list