RFR (M) 8211131: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[G-I]*

Alex Menkov alexey.menkov at oracle.com
Tue Oct 2 00:55:57 UTC 2018

Hi Jc,

Looking at your conversion script I expected things like

          if (!NSK_JVMTI_VERIFY(
                NSK_CPP_STUB2(AddCapabilities, jvmti, &caps))) {

to be converted to

if (!NSK_JVMTI_VERIFY(jvmti->AddCapabilities(&caps))) {

(then the final string is shorter than 100 symbols)

But actually I see

-                NSK_CPP_STUB2(AddCapabilities, jvmti, &caps))) {
+                jvmti->AddCapabilities(&caps))) {


On 09/26/2018 20:37, JC Beyler wrote:
> Hi all,
> I continued the NSK_CPP_STUB removal with this webrev:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8211131/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejcbeyler/8211131/webrev.00/>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211131
> This does the first 50 files of the jvmti subfolder, it is done 
> automatically by the scripts I put in the bug comments.
> Let me know what you think,
> Jc

More information about the serviceability-dev mailing list