[8u-backport] RFR: JDK-8193879: Java debugger hangs on method invocation

JC Beyler jcbeyler at google.com
Thu Oct 11 15:53:29 UTC 2018

Hi Fairoz,

The backport looks good to me (not a reviewer though) but I was wondering
why you are porting the two methods (getTestSourcePath and
parseBreakpoints) into this test? If we port other tests that would require
it, would we be doing the same or factorizing the methods into a helper
class ?

Last nit, those methods could be private no?


On Thu, Oct 11, 2018 at 6:22 AM Fairoz Matte <fairoz.matte at oracle.com>

> Hi,
> Kindly review the backport of "JDK-8193879: Java debugger hangs on method
> invocation" to 8u
> Code is almost cleanly applied, test case has been modified to fit into
> the JDK8 test framework.
> Webrev - http://cr.openjdk.java.net/~fmatte/8193879/webrev.00/
> JBS bug - https://bugs.openjdk.java.net/browse/JDK-8193879
> JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/218b5b64f102
> Review thread -
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025365.html
> Thanks,
> Fairoz


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181011/49b63922/attachment.html>

More information about the serviceability-dev mailing list