RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

gary.adams at oracle.com gary.adams at oracle.com
Wed Oct 17 19:40:44 UTC 2018

On 10/17/18 2:04 PM, Chris Plummer wrote:
> Hi Gary,
> Can this be on one line now:
>   30  * @modules
>   31  *          jdk.jdi
> What are you blocking all jdk.* classes from redef when you pointed 
> out that only jdk.internal.* is an issue?
The file I'm modifying already has some blocking checks that look
for java., com, and sun., so it seemed appropriate that the jdk. prefix
was appropriate for this check.
> Is this also addressing JDK-8180804? If not, should it stay on the 
> problem list until JDK-8180804 is fixed?
I'll run through the usual testing to see if I can force the timeout.
Since the test has been on the ProblemList for a year and half
it is hard to know if this is an intermittent failure or not.

If I can't reproduce the failure, then I'd like to go ahead with this
change and see if it shows up again.

The original reason the test was placed on the ProblemList
was because of the removal of java ee modules, not because of the
timeout that was observed.
> thanks,
> Chris
> On 10/17/18 9:46 AM, Gary Adams wrote:
>> The RedefineCrossEvent test has been on been on the ProblemList for a 
>> very long time.
>> In the past this test had some dependency on the Java EE modules, but 
>> they  were
>> deprecated for jdk9 and later removed completely in jdk11. This 
>> changeset to restore
>> it, removes the corba module reference and blocks the redefine 
>> operations
>> for jdk.internal classes that presented an issue when the 
>> RedefineCrossEvent
>> test launches the InstanceFilter test.
>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8206330
>>   Webrev: http://cr.openjdk.java.net/~gadams/8206330/webrev/index.html

More information about the serviceability-dev mailing list