RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Oct 17 23:26:52 UTC 2018

Hi Gary,

With the suggest tweaks below the fix looks good to me (modulo 
suggestions from Alex in the following message).
I'm Okay with any approach related to the problem list.
It looks wrong to keep the test problem listed with the same bug id.
If we want to keep it then the bug id needs to be replaced with 8180804.


On 10/17/18 12:58, Chris Plummer wrote:
> On 10/17/18 12:40 PM, gary.adams at oracle.com wrote:
>> On 10/17/18 2:04 PM, Chris Plummer wrote:
>>> Hi Gary,
>>> Can this be on one line now:
>>>   30  * @modules
>>>   31  *          jdk.jdi
>> OK
>>> What are you blocking all jdk.* classes from redef when you pointed 
>>> out that only jdk.internal.* is an issue?
>> The file I'm modifying already has some blocking checks that look
>> for java., com, and sun., so it seemed appropriate that the jdk. prefix
>> was appropriate for this check.
> Ok.
>>> Is this also addressing JDK-8180804? If not, should it stay on the 
>>> problem list until JDK-8180804 is fixed?
>> I'll run through the usual testing to see if I can force the timeout.
>> Since the test has been on the ProblemList for a year and half
>> it is hard to know if this is an intermittent failure or not.
>> If I can't reproduce the failure, then I'd like to go ahead with this
>> change and see if it shows up again.
> Ok.
>> The original reason the test was placed on the ProblemList
>> was because of the removal of java ee modules, not because of the
>> timeout that was observed.
> Yes, I realize that. But if the timeout is also somewhat new, it could 
> be problematic enough to warrant keeping it on the problem list.
> thanks,
> Chris
>>> thanks,
>>> Chris
>>> On 10/17/18 9:46 AM, Gary Adams wrote:
>>>> The RedefineCrossEvent test has been on been on the ProblemList for 
>>>> a very long time.
>>>> In the past this test had some dependency on the Java EE modules, 
>>>> but they  were
>>>> deprecated for jdk9 and later removed completely in jdk11. This 
>>>> changeset to restore
>>>> it, removes the corba module reference and blocks the redefine 
>>>> operations
>>>> for jdk.internal classes that presented an issue when the 
>>>> RedefineCrossEvent
>>>> test launches the InstanceFilter test.
>>>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8206330
>>>>   Webrev: http://cr.openjdk.java.net/~gadams/8206330/webrev/index.html

More information about the serviceability-dev mailing list