RFR (M) 8213003: Remove more assignments in ifs for vmTestbase/[a-s]

Claes Redestad claes.redestad at oracle.com
Wed Oct 31 10:16:06 UTC 2018


here's a case that your script seems to miss:


      if (!NSK_JNI_VERIFY(jni, (testedFieldID =
              jni->GetStaticFieldID(testedClass, FIELD_NAME, FIELD_SIGNATURE)) != NULL))

I'd note that with some of your changes here you're unconditionally executing logic outside of NSK_JNI_VERIFY macros. Does care need be taken to wrap the code blocks in equivalent macros/ifdefs? Or are the NSK_JNI_VERIFY macros always-on in these tests (and essentially pointless)?


On 2018-10-31 05:42, JC Beyler wrote:
> Hi all,
> I worked on updating my script and handling more assignments so I 
> redid a second pass on the same files to get all the cases. Now, on 
> those files the regex "if.* = " no longer shows any cases we would 
> want to fix.
> Could I get a review for this webrev:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8213003/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8213003
> I tested this on my dev machine by passing all the tests that were 
> modified.
> Thanks!
> Jc

More information about the serviceability-dev mailing list