<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Sounds like we have a consensus.<br>
<br>
Thanks, Paul!<br>
Serguei<br>
<br>
<br>
On 2/12/19 07:30, Hohensee, Paul wrote:<br>
</div>
<blockquote type="cite"
cite="mid:04848470-0B2A-4F36-8E3D-87581FEB74D3@amazon.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<div class="WordSection1">
<p class="MsoNormal">I agree, let’s leave the dump option alone
for now. Changing “and†to “or†is just a slight grammar
correctness fix.</p>
<p class="MsoNormal">Â </p>
<p class="MsoNormal">Thanks,</p>
<p class="MsoNormal">Â </p>
<p class="MsoNormal">Paul</p>
<p class="MsoNormal">Â </p>
<div>
<p class="MsoNormal"><b><span>From: </span></b><span><a class="moz-txt-link-rfc2396E" href="mailto:serguei.spitsyn@oracle.com">"serguei.spitsyn@oracle.com"</a>
<a class="moz-txt-link-rfc2396E" href="mailto:serguei.spitsyn@oracle.com"><serguei.spitsyn@oracle.com></a><br>
<b>Date: </b>Monday, February 11, 2019 at 6:33 PM<br>
<b>To: </b></span><span>臧ç³</span><span>
<a class="moz-txt-link-rfc2396E" href="mailto:zanglin5@jd.com"><zanglin5@jd.com></a>, "Joseph D. Darcy"
<a class="moz-txt-link-rfc2396E" href="mailto:joe.darcy@oracle.com"><joe.darcy@oracle.com></a>, "Hohensee, Paul"
<a class="moz-txt-link-rfc2396E" href="mailto:hohensee@amazon.com"><hohensee@amazon.com></a>, David Holmes
<a class="moz-txt-link-rfc2396E" href="mailto:david.holmes@oracle.com"><david.holmes@oracle.com></a>, JC Beyler
<a class="moz-txt-link-rfc2396E" href="mailto:jcbeyler@google.com"><jcbeyler@google.com></a><br>
<b>Cc: </b><a class="moz-txt-link-rfc2396E" href="mailto:serviceability-dev@openjdk.java.net">"serviceability-dev@openjdk.java.net"</a>
<a class="moz-txt-link-rfc2396E" href="mailto:serviceability-dev@openjdk.java.net"><serviceability-dev@openjdk.java.net></a><br>
<b>Subject: </b>Re: [RFR]8215622: Add dump to file
support for jmap histo</span></p>
</div>
<div>
<p class="MsoNormal">Â </p>
</div>
<div>
<p class="MsoNormal">Dear Lin,<br>
<br>
<br>
On 2/11/19 17:49, <span>臧ç³</span> wrote:</p>
</div>
<blockquote>
<pre>Dear All,</pre>
<pre>Â Â Â Â Thanks again for the comments.</pre>
<pre>Â Â Â Â one question from me is that "jmap -dump" must accept an argument indicates location of the heap dump file. if there is no such argument, it fails. (it is meaningless to output the binary directly to stdout/stderr for me.)</pre>
</blockquote>
<p class="MsoNormal"><br>
Does the option "<span class="pln"><span>format</span></span><span
class="pun"><span>=</span></span><span class="pln"><span>b"
tells us that the dump output can be in text format as
well?</span></span><span><br>
<span class="pln">The help tells nothing about what is the
default format.</span><br>
<span class="pln">I'd conclude that the default has to be
text format if the option "format</span><span class="pun">=</span><span
class="pln">b" is missed.</span><br>
<br>
<span class="pln">Now, I'm looking at the option processing
in the dump() method and see that option "format</span><span
class="pun">=</span><span class="pln">b" is not really
processed but just filtered out.</span><br>
<span class="pln">It means that you are right, the only
supported dumping format is binary.</span><br>
<br>
<span class="pln">In this situation, I withdraw my
suggestion to allow empty <dump-options>.</span><br>
<span class="pln">At least, you do not need to care about
it.</span><br>
<span class="pln">However, there is still the suggestion
from Paul to replace "and" with "or" in both dump-options
and histo-options.</span><br>
</span><br>
<br>
</p>
<blockquote>
<pre>Â Â Â Â so adding "jmap -dump" actually just output error message like "No dump file specified", rather than print the usage of JMap as implemented now.</pre>
<pre>Â Â Â Â And this is also why there is no "-dump" or "-dump:" test in BasicJMapTest.java.</pre>
</blockquote>
<p class="MsoNormal"><br>
I leave it to other people to decide what is better here.<br>
<br>
<br>
</p>
<blockquote>
<pre>Â Â Â Â Another option is to add default file generated at canonical path for -dump. then I can add the unit test.</pre>
<pre>Â Â Â Â which one do you think is more reasonable?</pre>
</blockquote>
<p class="MsoNormal"><br>
It looks like a good idea.<br>
But I'm not sure about it yet.<br>
Let's see what others say.<br>
<br>
<br>
</p>
<blockquote>
<pre>Â Â Â Â Moreover, one minor thing is that BasicJMapTest right now has test for "jmap -histo:" , not for "jmap -histo", so I think I need to add test for that. is this OK?</pre>
</blockquote>
<p class="MsoNormal"><br>
Yes.<br>
<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
</p>
<blockquote>
<pre>Â </pre>
<pre>Cheers,</pre>
<pre>Lin</pre>
<pre>________________________________________</pre>
<pre>From: Joseph D. Darcy <a href="mailto:joe.darcy@oracle.com" moz-do-not-send="true"><joe.darcy@oracle.com></a></pre>
<pre>Sent: Tuesday, February 12, 2019 6:22:59 AM</pre>
<pre>To: Hohensee, Paul; <a href="mailto:serguei.spitsyn@oracle.com" moz-do-not-send="true">serguei.spitsyn@oracle.com</a>; <span>臧ç³</span>; David Holmes; JC Beyler</pre>
<pre>Cc: <a href="mailto:serviceability-dev@openjdk.java.net" moz-do-not-send="true">serviceability-dev@openjdk.java.net</a></pre>
<pre>Subject: Re: [RFR]8215622: Add dump to file support for jmap histo</pre>
<pre>Â </pre>
<pre>On 2/11/2019 2:20 PM, Hohensee, Paul wrote:</pre>
<blockquote>
<pre>The CSR was just closed, so we're stuck with doing another one later.</pre>
</blockquote>
<pre>Before a changeset is pushed, its CSR can be amended (Withdraw or back</pre>
<pre>to draft, then refinalize after editing.)</pre>
<pre>Â </pre>
<pre>HTH</pre>
<pre>Â </pre>
<pre>-Joe</pre>
</blockquote>
<p class="MsoNormal"><br>
<br>
</p>
</div>
</blockquote>
<br>
</body>
</html>