Proposed revised format for JDK commit messages
erik.helin at oracle.com
Mon Sep 17 18:02:42 UTC 2018
On 09/17/2018 06:29 PM, Erik Helin wrote:
> How about changing whats get recorded for a sponsored commit? We could
> let the author be recorded in the author field and then have a
> "Sponsored-by" line? This way we could also encode the sponshorship for
> commits from a person with role "Author" (the "Author" would of course
> be the author and we would add an "Sponsored-by" line for the sponsor).
...and, as usual when not thinking about a problem for a while, a third
idea popped up :)
We could utilize the fact that git has two different fields in a commit
for recording different kinds of authorship:
The person who applied, ev. merged and then pushed the patch
The person who created the patch
Git's notion of committer is fairly close to our concept of sponsor (a
sponsor has a bit more responsibility than just committing and pushing
the patch). So another suggestion would therefore be to utilize the
committer field for recording the sponsor.
For "regular" pushes from a person with role "Committer" or above, the
committer field and the author field would be the same (assuming the
person with "Committer" status also wrote the patch).
So, two suggestions for encoding sponsorship while still letting author
- add a "Sponsored-by" line
- use the committer field for recording the sponsor
What do you think?
More information about the skara-dev