Proposed revised format for JDK commit messages
erik.helin at oracle.com
Tue Sep 18 07:49:37 UTC 2018
On 9/17/18 6:48 PM, Alan Bateman wrote:
> On 17/09/2018 17:29, Erik Helin wrote:
>> There are ways we can record the sponshorship, see my reply further
>> down. Just for my understanding: this only applies to contributions
>> from persons with the "Participant" role ? Persons with role
>> "Author"  still needs a sponsor but we don't record that
>> sponsorship, right?
> It depends on who creates the change-set. Sometimes a contributor with
> Author role will create the change-set themselves and the sponsor will
> do the push. The sponsor will usually have reviewed the change so will
> be listed in the Reviewed-by line but you might find a few cases where
> the sponsor wasn't involved in the review, instead they are just helping
> out. At other times, the sponsor will create the change-set (and so be
> the change-set author) and list the contributor in the Contributed-by
> line today. In general there isn't any specific to contributors with
> Author role here - I can think of a few cases where a Committer or
> Reviewer developed patches that were turned into change-sets and pushed
> by someone else (with the appropriate Contributed-by line of course).
Thanks Alan for your thoughts on this matter, I agree that in almost all
cases the sponsor for an "Author" patch will be one of the reviewers (at
least that is my personal experience).
As in wrote in my reply to Mark (and myself), I think it makes sense to
encode the sponshorship using either a "Sponsored-by" line or using the
committer field in git. What do you think about this?
Thanks for taking your time to read through this proposal and providing
feedback, much appreciated!
More information about the skara-dev