Proposed revised format for JDK commit messages
per.liden at oracle.com
Wed Sep 19 07:20:47 UTC 2018
On 09/17/2018 06:27 AM, joe darcy wrote:
> ReviewersLine : "Reviewed-by: " Username (", " Username)* "\n"
> ContributedByLine : "Contributed-by: " Text
> 8167108: inconsistent handling of SR_lock can lead to crashes
> Add Thread Safe Memory Reclamation (Thread-SMR) mechanism.
> Reviewed-by: coleenp, dcubed, dholmes, eosterlund, gthornbr,
> kbarrett, rehn, sspitsyn, stefank
> Co-authored-by: Erik Osterlund <erik.osterlund at oracle.com>
> Co-authored-by: Robbin Ehn <robbin.ehn at oracle.com>
> Co-authored-by: Igor Ignatyev <igor.ignatyev at oracle.com>
It would feel natural to have all *-by lines follow the same syntax. The
Reviewed-by line sticks out in this regard. Is there a reason why we
don't just do:
Reviewed-by: Some Name <some.name at oracle.com>
Reviewed-by: Some Other Name <some.other.name at oracle.com>
... and so on?
More information about the skara-dev