RFR: Fix 2 failing tests due to URI syntax errors

Erik Duveblad via github.com duke at openjdk.java.net
Thu Aug 22 13:10:35 UTC 2019

On Thu, 22 Aug 2019 13:01:59 GMT, Jorn Vernee via github.com <duke at openjdk.java.net> wrote:

> There were 2 tests failing due to incorrect URI syntax resulting from directly using a path string as URI, which on Windows will contain incorrect path separators.
> This PR forces the path separators to be unix ones, and inserts an explicit leading slash before the local path starts (both are needed according to the URI spec).
> ----------------
> Commits:
>  - 3ea02c85:	Force unix line endings when creating URI, and use three slashes which is needed if no hostname is in the URI
> Pull request:
> https://git.openjdk.java.net/skara/pull/69
> Webrev:
> https://webrevs.openjdk.java.net/skara/69/webrev.00
> Patch:
> https://git.openjdk.java.net/skara/pull/69.diff
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/69/head:pull/69

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Looks good, thanks for fixing!

PR: https://git.openjdk.java.net/skara/pull/69

More information about the skara-dev mailing list