RFR: Add topological merge bot
Erik Duveblad via github.com
duke at openjdk.java.net
Thu Aug 29 12:58:38 UTC 2019
On Thu, 29 Aug 2019 12:28:41 GMT, Jorn Vernee via github.com <duke at openjdk.java.net> wrote:
> This PR adds a bot that does a topological merge of the branches in a repo.
> The branches can declare a dependencies file, which lists the branches that they depend on. This bot will crawl the branches, collect the dependencies for each branch, and topologically sort them based on their dependencies. Following that it will attempt to merge each dependency into the dependent in this order (this is mainly done so that we get less merges/failures if one of the root merges fails).
> Branches that do not declare a dependency file implicitly depend on the master branch. Therefore the list of branches that the bot considers is passed in during configuration.
> Aside from that, it also fixes a minor problem with `Repository::clone` on Windows.
> - 4a8f3610: Added top bot module
> Pull request:
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/105/head:pull/105
Hi Jorn, thanks for the contribution! :clap:
Just a quick suggestion after a brief look - how about moving `Edge` to its own file, `Edge.java` and also move `tsort` into its own class, `TopologicalSort` (in `TopologicalSort.java`)? That way you should have a fairly easy time to add a new test class, `TopologicalSortTests`, with some unit tests for the topological sort
More information about the skara-dev