[Rev 04] RFR: Fix parsing of editor commandline in git-pr
rwestberg at openjdk.java.net
Wed Feb 12 08:35:10 UTC 2020
On Tue, 11 Feb 2020 13:22:23 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> For git editor configurations that aren't a simple call to an editor but have more parameters, the starting of the editor in git pr does not work.
>> At least, I observed this in my windows environment, where I have the following git config entry:
>> core.editor="C:\\Program Files\\Notepad++\\notepad++.exe" -multiInst -notabbar -nosession -noPlugin
> The pull request has been updated with a new target base due to a merge or a rebase.
Looks good to me! Hopefully we won't need more complex shell lexing than this :) My only concern is that the quotes will remain around the arguments, but I guess that's fine for at least the binary name.
Marked as reviewed by rwestberg (Reviewer).
More information about the skara-dev