RFR: 217: Enforce check on number of required reviewers
rwestberg at openjdk.java.net
Mon Jan 20 15:08:24 UTC 2020
On Fri, 17 Jan 2020 14:27:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> In addition to allowing a reviewer to increase the required number of reviewers, which is the use case described in the Enhancement request, this will allow a reviewer to reduce the number of required reviewers below the minimum set in `.jcheck/conf`, including setting it to 0, right? Is this what we want?
> One more question: If I increase the number of required reviewers to 2, does that mean both have to have the Reviewer role? If so, this won't be nearly as useful to us on the openjfx project. I suspect the same is true of many sub-projects in the JDK itself. For example, the policy in the client team is that fixes in general need 2 reviewers, at least one of which must be a "R" reviewer. OpenJFX has a similar policy (except that only "high-impact" fixes need a second reviewer) in that only one of the reviewers needs to be a "R" reviewer.
Now that #368 has been implemented, I'll update this to support more complex reviewer requirements. Also, it makes sense not to allow relaxing the requirements below what the jcheck configuration specifies.
More information about the skara-dev