RFR: 244: Legacy reviewers jcheck configuration does not reset default
rwestberg at openjdk.java.net
Fri Jan 24 06:54:15 UTC 2020
On Thu, 23 Jan 2020 17:24:02 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
> please review this patch that fixes an issue with the parsing of the older
> format of the "reviewers" jcheck configuration. The problem is that the defaults
> weren't reset when parsing the older format, so if a repository has a
> `.jcheck/conf` containing the following
> [checks "reviewer"]
> minimum = 1
> role = committer
> then the outcome would be the that jcheck would require 1 Reviewer and 1
> Committer (since the default is 1 Reviewer).
> The fix is to reset the defaults to zero when parsing the older format.
> ## Testing
> - [x] Added a new unit test for the above scenario
Marked as reviewed by rwestberg (Reviewer).
More information about the skara-dev