RFR: 416: Expose committer date in CommitMetadata

Robin Westberg rwestberg at openjdk.java.net
Mon Jun 15 13:09:36 UTC 2020

On Mon, 15 Jun 2020 13:00:25 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that removes the `date()` method in `CommitMetadata` and adds `authored()` and `committed()`.
> For Mercurial commits `authored()` will equal `committed()` since Mercurial does not support different author and
> committer dates.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/664

More information about the skara-dev mailing list