RFR: 420: Expand JBS issues in PR titles

Robin Westberg rwestberg at openjdk.java.net
Wed Jun 17 16:36:25 UTC 2020

On Wed, 17 Jun 2020 16:08:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that automatically expands issue ids in pull request titles to the "id: title" format.
> For example if a pull request for the [skara](https://github.com/openjdk/skara) repository has the title `420`, then
> the pull request title will be automatically set to `420: Expand JBS issues in PR titles`. I have been fairly
> conservative in what we expand, we only expand titles exactly matching `PROJECT-ID` or `ID`, i.e. `SKARA-420` or
> `420`.  Testing:
> - [x] Added two new unit tests
> - [x] `make test` passes on Linux x64
> Thanks,
> Erik

Looks good! Perhaps it would be nice with a test that checks that non-matching titles aren't expanded, but it looks
like it should work correctly. )


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/672

More information about the skara-dev mailing list