RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2]

Robin Westberg rwestberg at openjdk.java.net
Wed Jun 24 13:38:40 UTC 2020

On Wed, 24 Jun 2020 10:15:32 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with two additional commits since the last revision:
>>  - Allow using / as a component/subcomponent separator
>>    Remove debug print statement
>>  - Only allow creating issues of type "enhancement" for now
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 216:
>> 215:     private void createIssue(PullRequestBot bot, PullRequest pr, String args, CensusInstance censusInstance,
>> HostUser author, PrintWriter reply) { 216:         if (!censusInstance.isAuthor(author)) {
>> 217:             reply.println("Only [Authors](https://openjdk.java.net/bylaws#author) are allowed to create issues.");
> DId you mean to check for committer status? In the description of the PR you wrote for "Committers" and above, but here
> you are checking for "Author" and above

No, I should have written Author in the PR description, think that check is sufficient as all authors have permissions
to create issues manually in JBS.


PR: https://git.openjdk.java.net/skara/pull/677

More information about the skara-dev mailing list