[cr] Integrated: index.html: inline js
ehelin at openjdk.java.net
Fri Apr 16 08:54:49 UTC 2021
On Fri, 16 Apr 2021 08:46:34 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
> please review this patch that inlines `webrev.js` into `index.html` to avoid an additional network request. It would have been better to keep the JS in a separate file if we could:
> - minify the JS
> - configure cache control headers
> GitHub Pages unfortunately does not allow any of the above (and we don't want a build step for minification), therefore the best option is to inline the JS into `index.html`.
This pull request has now been integrated.
Author: Erik Helin <ehelin at openjdk.org>
Stats: 3034 lines in 2 files changed: 1506 ins; 1528 del; 0 mod
index.html: inline js
More information about the skara-dev