[cr] RFR: 988: Skara webrev is empty if patch has deleted files
erikj at openjdk.java.net
Thu Apr 22 21:38:36 UTC 2021
If a file in the patch has been deleted this causes a dereference of an undefined value. To fix this I removed the quick return in fetchFileContent so that this function always returns a value.
While verifying this, I also noted that the deleted file gets a Raw link which results in a 404. I think it should just not print the Raw link so I removed that too.
If a file has only been renamed, with no other changes, the patch will be an empty string. This upsets the hunk look, so I added a case for handling this.
The resulting webrevs from the two reported patches look correct to me with these changes, but I would appreciate some more eyes on this.
- Handle deleted and renamed files without error
Stats: 10 lines in 1 file changed: 2 ins; 6 del; 2 mod
Fetch: git fetch https://git.openjdk.java.net/cr pull/14/head:pull/14
More information about the skara-dev