RFR: 983: Github commit links 404
kcr at openjdk.java.net
Thu Apr 22 23:07:13 UTC 2021
On Thu, 22 Apr 2021 22:38:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> Sometimes our abbreviated commit web links on Github are not working. My guess is that this is caused by collisions. I think the correct fix here is to stop abbreviating commit hashes in links. Github internal links seem to always be full hashes, while pretty printing the link text with an abbreviation. We should adopt the same basic principle.
Conceptually, this looks like the right fix to me. A couple questions:
1. Do all places that generate a commit URL use the `webUrl` method?
2. Are there any places that extract the printed name from the URL (if so, those would now print the full 40 char hash)?
3. Are there place other than `IssueNotifer::onNewCommits` where you might need to check for old versus new hashes? I think this would only be a problem if there were other similar places that checked whether the URL had already been seen.
4. Are there any tests that need to be updated (or written)?
More information about the skara-dev