RFR: 868: Skara should ignore .gitconfig and /etc/gitconfig

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Feb 2 13:53:03 UTC 2021

On Tue, 2 Feb 2021 13:23:34 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Skara is already ignoring .hgrc for mercurial, but the corresponding solution for git was never put in place.
>> I also fixed a problem where an error condition would cause an infinite loop, which I ran into during testing.
> @magicus thanks for contributing! What do you think about adding a unit test to `RepositoryTests.java`?

@edvbld What exactly do you propose to test in the unit test? This is really solving a problem with the environment -- the tests fail when I run as my user due to conflicting modifications in my `~/.gitconfig`. I can't really modify the users personal gitconfig file in a unit test. The only thing I could really think if is verifying that `git config -l` is empty. Hm, maybe that's a good idea...


PR: https://git.openjdk.java.net/skara/pull/997

More information about the skara-dev mailing list