RFR: 868: Skara should ignore .gitconfig and /etc/gitconfig [v3]

Erik Helin ehelin at openjdk.java.net
Thu Feb 4 14:41:56 UTC 2021

On Wed, 3 Feb 2021 11:18:06 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Skara is already ignoring .hgrc for mercurial, but the corresponding solution for git was never put in place.
>> I also fixed a problem where an error condition would cause an infinite loop, which I ran into during testing.
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>   Add unit test to verify that we block user/system configs.

Looks good, just a minor comment inline.

process/src/main/java/org/openjdk/skara/process/Process.java line 70:

> 68:         }
> 69: 
> 70:         public Description environMap(Map<String, String> keyValueMap) {

I would have just overloaded `environ`, as in `public Description environ(Map<String, String> env)`


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/997

More information about the skara-dev mailing list