RFR: pr: handle exceptions for commit commands

Robin Westberg rwestberg at openjdk.java.net
Mon Feb 15 13:04:18 UTC 2021

On Mon, 15 Feb 2021 12:59:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that properly handles `RuntimeException`s thrown by commit commands.
> Testing:
> - [x] `make test` passes on Linux x64
> Thanks,
> Erik

Looks good in general, but it may be prudent to change processedCommitComments to a concurrent type now that it can be accessed from another context.


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1017

More information about the skara-dev mailing list