[skara] RFR: forge: pass commit-title-to-commits map to GitLab

Robin Westberg rwestberg at openjdk.java.net
Wed Feb 24 15:51:27 UTC 2021

On Wed, 24 Feb 2021 15:45:18 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that greatly simplifies `GitLabRepository.recentCommitComments`. Now that `CommitCommentsWorkItem` has a `Repository` instance anyhow for filtering out applicable commits, we can use that to create a "commit titles to commits" map and pass that to `GitLabRepository.recentCommitComments`. This greatly speeds up the function call (avoid a bunch of expensive REST requests). Other forges can just ignore the argument.
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1035

More information about the skara-dev mailing list