RFR: 1069: PR ends up in bad state if interrupted just after push

Erik Joelsson erikj at openjdk.java.net
Tue Jun 8 13:43:26 UTC 2021

On Mon, 7 Jun 2021 23:23:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java line 196:
>>> 194:             }
>>> 195: 
>>> 196:             var backportLines = allComments
>> This is a slight optimization. We already have a list of all comments, so no need to reach out to github to fetch them again. I can't see any need in this situation to refresh either.
> So there's no need to ever refresh after acquiring the integration lock?

Not sure, I don't think the IntegrationLock is relevant for this, as it's not involved in the CheckWorkItem where this comment would potentially be created, but maybe I should still leave this alone as I'm not sure about how the concurrency could play out here.

Investigating this made me discover that there is a duplicate implementation of this whole thing in the SponsorCommand that I need to address.


PR: https://git.openjdk.java.net/skara/pull/1183

More information about the skara-dev mailing list