Integrated: 1072: Skara should validate the commit hash of a Backport PR
erikj at openjdk.java.net
Wed Jun 9 15:01:18 UTC 2021
On Mon, 7 Jun 2021 23:09:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> Add a check for "Backport <hash>" titles that the given hash isn't the head of the PR itself. If the user mistakenly uses that hash, Skara is very likely to get fooled into thinking the backport is clean.
> While investigating this, I also discovered that the CheckWorkItem was inconsistent with not repeating "backport" errors, so I implemented a general mechanism for this, which guarantees that the same exact error message is never repeated. I believe this will be good enough, and certainly better than the existing behavior.
This pull request has now been integrated.
Author: Erik Joelsson <erikj at openjdk.org>
Stats: 244 lines in 4 files changed: 224 ins; 12 del; 8 mod
1072: Skara should validate the commit hash of a Backport PR
More information about the skara-dev