RFR: 1076: Not possible to use 'Backport <sha>' if original bug doesn't have public sha [v3]

Erik Joelsson erikj at openjdk.java.net
Fri Jun 11 19:59:49 UTC 2021

On Fri, 11 Jun 2021 18:53:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>   Review comments
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/BackportTests.java line 1458:
>> 1456:             assertEquals(List.of(), message.contributors());
>> 1457:             assertEquals(List.of(), message.summaries());
>> 1458:             assertEquals(List.of(), message.additional());
> It might be good to also check that the commit message does not contain "Backport of", or is this covered by checking that `message.additional()` is empty?

Good point. I just removed the assert for the existence of the original hash without thinking about inverting that assert.


PR: https://git.openjdk.java.net/skara/pull/1186

More information about the skara-dev mailing list