RFR: 997: Email notifications are not sent to alias if binary change is commented in Gitlab

Erik Joelsson erikj at openjdk.java.net
Wed Jun 16 23:50:42 UTC 2021

This fixes an NPE when parsing a review comment from Gitlab on a binary file. Such a comment does not have a line, and I picked the value 0 to signal that. I also updated the email formatting of such comments to skip showing line numbers and quotes from the file.


Commit messages:
 - SKARA-997

Changes: https://git.openjdk.java.net/skara/pull/1190/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1190&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-997
  Stats: 46 lines in 3 files changed: 29 ins; 3 del; 14 mod
  Patch: https://git.openjdk.java.net/skara/pull/1190.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1190/head:pull/1190

PR: https://git.openjdk.java.net/skara/pull/1190

More information about the skara-dev mailing list