RFR: 997: Email notifications are not sent to alias if binary change is commented in Gitlab [v2]

Kevin Rushforth kcr at openjdk.java.net
Thu Jun 17 11:58:33 UTC 2021

On Thu, 17 Jun 2021 00:04:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This fixes an NPE when parsing a review comment from Gitlab on a binary file. Such a comment does not have a line, and I picked the value 0 to signal that. I also updated the email formatting of such comments to skip showing line numbers and quotes from the file.
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>   Clarified comment

Looks good.


Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1190

More information about the skara-dev mailing list