RFR: pr: update all local branches for commit comments [v2]
rwestberg at openjdk.java.net
Wed Mar 10 10:22:09 UTC 2021
On Wed, 10 Mar 2021 10:19:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Hi all,
>> please review this patch that makes `CommitCommentsWorkItem` properly update all local branches prior to calling `ReadOnlyRepository.commitMetdata`. `ReadOnlyRepository.commitMetadata` is essentially `rev-list —all` for Git and all local refs need to be updated for this to work. In order to make as few networks call as possible I manually merge each local branch with its remote counterpart (instead of doing `pull`).
>> - [x] `make test` passes on Linux x64
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
> No need to fetch remotes
Marked as reviewed by rwestberg (Reviewer).
More information about the skara-dev