RFR: Add support for using ssh cloning with GitLab

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Mar 15 12:50:26 UTC 2021

On Mon, 15 Mar 2021 12:38:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabForgeFactory.java line 63:
>>> 61:         var existingMatcher = existingBlock.matcher(existing);
>>> 62:         var filtered = existingMatcher.replaceAll("");
>>> 63:         var result = "Match host=" + userHost + "\n" +
>> I don't think this is valid .ssh/config syntax. Afaik it should be `Match <keyword> <value>`, that is, no `=`. I see no tests in this PR. Are you sure this works?
> Yes, tested it manually and seems to work fine. And no, there are no automated tests that exercise GitLab or GitHub APIs, except for running them with a special credential configuration..

I still think this does not follow the documented ssh config file syntax (https://man7.org/linux/man-pages/man5/ssh_config.5.html). And even if that works on your machine right now, it can break on a future update of ssh.


PR: https://git.openjdk.java.net/skara/pull/1057

More information about the skara-dev mailing list